-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav Redesign: Add notifications pointer #90495
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~155 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~2091 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~17837 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised.
( englishLocales.includes( this.props.locale ) || | ||
hasTranslation( 'Looking for your notifications? They have been moved here.' ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it better to hide the message than showing it un-translated? Should we block merging this PR until we have the text translated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it better to hide the message than showing it un-translated?
Because untranslated content is a pain point for our customers (pxLjZ-5Ir-p2, p58i-8e8-p2)
Should we block merging this PR until we have the text translated?
I think it's better if English users see this change immediately
Looks great :) Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended!
Follow-up of #90429
Proposed Changes
Adds a pointer to indicate that notifications have been moved to the bottom (as of #90429) since users might be confused trying to find it in the previous location (see p1715182058030399-slack-C9EJ7KSGH).
The pointer has been designed to only be visible for users registered before we moved the notifications and will remain only visible for two weeks. In a follow-up, we'll need to remove this code.
Testing Instructions
/sites